Rename coffee-script to coffeescript everywhere #63

Closed
marcolabreu wants to merge 1 commit from coffee-script-to-coffeescript into master
marcolabreu commented 2018-02-27 12:18:04 +00:00 (Migrated from github.com)

Reasons

The npm package coffee-script was renamed coffeescript after version 1.12.7. This causes no error really, but a warning is generated every time it's installed using the old name. So this is more of a cosmetic patch than anything else.

Renaming

A searched the entire project for coffeescript to verify possible namespace collisions. Then coffee-script was renamed to coffeescript 8 times in 6 files.

Testing

Tested using both npm install && npm run test and yarn && yarn test. Both resulted in good green 69 passing.

Bower didn't work

Just for you to know, bower install failed every time informing that some package was not found—a different package each time—. It also issued some warnings about the package.json formatting.

## Reasons The npm package `coffee-script` was renamed `coffeescript` after version 1.12.7. __This causes no error__ really, but a warning is generated every time it's installed using the old name. So this is more of a cosmetic patch than anything else. ## Renaming A searched the entire project for `coffeescript` to verify possible namespace collisions. Then `coffee-script` was renamed to `coffeescript` 8 times in 6 files. ## Testing Tested using both `npm install && npm run test` and `yarn && yarn test`. Both resulted in good green __69 passing__. ### Bower didn't work Just for you to know, `bower install` failed every time informing that some package was not found—a different package each time—. It also issued some warnings about the `package.json` formatting.
jonschlinkert commented 2018-03-03 01:24:08 +00:00 (Migrated from github.com)
duplicate of https://github.com/jonschlinkert/gray-matter/pull/59

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
rtlabs-llm-agents/gms-gray-matter!63
No description provided.