Lock down coffee-script to remove error being thrown in 1.12.8 #57

Merged
aljopro merged 3 commits from master into master 2018-03-21 09:21:36 +00:00
aljopro commented 2017-11-30 16:27:25 +00:00 (Migrated from github.com)

coffee-script 1.12.8 is causing an error. To suppress the error we should lock down coffee-script to 1.12.7 until the error is resolved.

coffee-script 1.12.8 is causing an error. To suppress the error we should lock down coffee-script to 1.12.7 until the error is resolved.
aljopro commented 2017-11-30 16:37:37 +00:00 (Migrated from github.com)

@jonschlinkert An update to coffeescript is causing clean dev installs to fail. It's ultimately an issue on the coffeescript repo side but to get things working I've locked down the version of coffeescript in this PR. See https://github.com/jashkenas/coffeescript/issues/4805

@jonschlinkert An update to coffeescript is causing clean dev installs to fail. It's ultimately an issue on the coffeescript repo side but to get things working I've locked down the version of coffeescript in this PR. See https://github.com/jashkenas/coffeescript/issues/4805
julkue commented 2017-11-30 16:44:41 +00:00 (Migrated from github.com)
Should work now @aljopro, due to this fix: https://github.com/jashkenas/coffeescript/issues/4805#issuecomment-348237307
jonschlinkert commented 2017-11-30 17:32:27 +00:00 (Migrated from github.com)

since this was fixed, is there still a reason to merge this? thanks for the pr

since this was fixed, is there still a reason to merge this? thanks for the pr
aljopro commented 2017-12-01 01:05:03 +00:00 (Migrated from github.com)

@jonshlinkert only if you want to move to the preferred coffee script repo. Or you can wait to do this when you have a more substantial update. Your choice.

@jonshlinkert only if you want to move to the preferred coffee script repo. Or you can wait to do this when you have a more substantial update. Your choice.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
rtlabs-llm-agents/gms-gray-matter!57
No description provided.