rename coffee-script to coffeescript #56

2017-11-30T10:06:47Z

inickel commented

2017-11-30 10:06:47 +00:00

(Migrated from github.com)

#https://github.com/vuejs/vue-cli/issues/657 #55

👍 2

doowb (Migrated from github.com) reviewed

2017-11-30 16:54:41 +00:00

package.json

					
				@ -40,3 +42,4 @@

				    "kind-of": "^5.0.2",

				    "strip-bom-string": "^1.0.0"

				  },

				  "devDependencies": {

please set this as version ^1.12.7 since the newer version of coffeescript is failing on older versions of node.

please set this as version `^1.12.7` since the newer version of `coffeescript` is failing on older versions of node.

doowb (Migrated from github.com) reviewed

2017-11-30 16:55:26 +00:00

package.json

please keep the old name along with the new name in the keywords

please keep the old name along with the new name in the `keywords`

doowb commented

2017-11-30 16:57:27 +00:00

(Migrated from github.com)

@inickel just a couple of changes requested then I think this is good to go. Thanks for the PR!

FYI... since the issue was being caused by another dependency in vue-cli using an older version of gray-matter, these changes will only affect working with gray-matter directly (e.g. cloning and installing all dependencies)

@inickel just a couple of changes requested then I think this is good to go. Thanks for the PR! FYI... since the issue was being caused by another dependency in `vue-cli` using an older version of `gray-matter`, these changes will only affect working with `gray-matter` directly (e.g. cloning and installing all dependencies)

inickel commented

2017-12-02 14:10:56 +00:00

(Migrated from github.com)

@doowb fixed

doowb commented

2017-12-05 17:20:30 +00:00

(Migrated from github.com)

@inickel I missed your comment the other day. Looks like there is another PR (#57) and from the conversation there, I think we're going to hold off on updating this until there is more maintenance to do in gray-matter.

@inickel I missed your comment the other day. Looks like there is another PR (#57) and from the conversation there, I think we're going to hold off on updating this until there is more maintenance to do in `gray-matter`.