Add runnable and parallel pkgs #3

Merged
tabboud merged 1 commit from ta/runnable into develop 2025-12-16 01:52:50 +00:00
tabboud commented 2025-12-05 19:08:36 +00:00 (Migrated from github.com)

Before this PR

After this PR

==COMMIT_MSG== Add runnable and parallel pkgs ==COMMIT_MSG==

Possible downsides?

## Before this PR <!-- What's wrong with the current state of the world and why change it now? --> ## After this PR <!-- User-facing outcomes this PR delivers go below --> ==COMMIT_MSG== Add runnable and parallel pkgs ==COMMIT_MSG== ## Possible downsides? <!-- Please describe any way users could be negatively affected by this PR. -->
changelog-app[bot] commented 2025-12-05 19:08:40 +00:00 (Migrated from github.com)

Generate changelog in changelog/@unreleased

Type (Select exactly one)

  • Feature (Adding new functionality)
  • Improvement (Improving existing functionality)
  • Fix (Fixing an issue with existing functionality)
  • Break (Creating a new major version by breaking public APIs)
  • Deprecation (Removing functionality in a non-breaking way)
  • Migration (Automatically moving data/functionality to a new system)

Description Add runnable and parallel pkgs

Check the box to generate changelog(s)

  • Generate changelog entry
### Generate changelog in <changelog-dir>`changelog/@unreleased`</changelog-dir> **Type** _(Select exactly one)_ <changelog-type> - [x] **Feature** (Adding new functionality) - [ ] **Improvement** (Improving existing functionality) - [ ] **Fix** (Fixing an issue with existing functionality) - [ ] **Break** (Creating a _new major version_ by breaking public APIs) - [ ] **Deprecation** (Removing functionality in a non-breaking way) - [ ] **Migration** (Automatically moving data/functionality to a new system) </changelog-type> **Description** <changelog-description> Add runnable and parallel pkgs </changelog-description><changelog-links></changelog-links> **Check the box to generate changelog(s)** - [x] Generate changelog entry
changelog-app[bot] commented 2025-12-05 19:08:55 +00:00 (Migrated from github.com)

✅ Successfully generated changelog entry!

Need to regenerate?

Simply interact with the changelog bot comment again to regenerate these entries.


📋Changelog Preview

✨ Features

  • Add runnable and parallel pkgs (#3)
### ✅ **Successfully generated changelog entry!** #### Need to regenerate? Simply interact with the changelog bot comment again to regenerate these entries. --- ### 📋Changelog Preview ### ✨ Features * Add runnable and parallel pkgs ([#3](https://github.com/palantir/witchcraft-go-tasks/pull/3)) <!-- changelog-success-comment -->
k-simons (Migrated from github.com) requested changes 2025-12-05 21:34:34 +00:00
@ -0,0 +22,4 @@
type RunFn func(ctx context.Context) error
// Runnable is a named object that can be run.
type Runnable interface {
k-simons (Migrated from github.com) commented 2025-12-05 21:29:32 +00:00

Should we call this a Task?

I would like to root primitive that we use across jobs/runnables to be shared. We could make this "Runnable", or we could make this "Task" and then then "Runnable" package would use the Task package.

Should we call this a Task? I would like to root primitive that we use across jobs/runnables to be shared. We could make this "Runnable", or we could make this "Task" and then then "Runnable" package would use the Task package.
@ -0,0 +24,4 @@
// Runnable is a named object that can be run.
type Runnable interface {
Run(ctx context.Context) error
Name() string
k-simons (Migrated from github.com) commented 2025-12-05 21:30:08 +00:00

We should compose this:

type Runnable interface { Run(ctx context.Context) error }

type NamedRunnable interface { Runnable GetName() string }

We should compose this: type Runnable interface { Run(ctx context.Context) error } type NamedRunnable interface { Runnable GetName() string }
@ -0,0 +12,4 @@
// See the License for the specific language governing permissions and
// limitations under the License.
package runnable
k-simons (Migrated from github.com) commented 2025-12-05 21:34:03 +00:00

I could see us removing this entire file FWIW. I really depends how server integration looks

I could see us removing this entire file FWIW. I really depends how server integration looks
k-simons commented 2025-12-16 01:52:26 +00:00 (Migrated from github.com)

👍

👍
k-simons (Migrated from github.com) approved these changes 2025-12-16 01:52:41 +00:00
Sign in to join this conversation.
No description provided.