On a quick note, I am having difficulties telling the difference of left from right in a map, even in a tree. I will pull in your request to a different branch and modify the naming to be explicit, i.e. "minimum and maximum" instead of "left and right" if that's OK with you. Additionally I think there is room for another more generic function within a tree "ceiling and flooring" which is the same thing except a node is passed as an argument. "minimum and maximum" in that case simply becomes a helper function for the same "ceiling and flooring" functions with the passed node being the root.

Once again, sorry for the delay and thanks!

Hi Vlad, thank you for your contribution and interest in the project. I have been on vacation and busy with other projects, so excuse the long response time. I will look into this within a day or two. On a quick note, I am having difficulties telling the difference of left from right in a map, even in a tree. I will pull in your request to a different branch and modify the naming to be explicit, i.e. "minimum and maximum" instead of "left and right" if that's OK with you. Additionally I think there is room for another more generic function within a tree "ceiling and flooring" which is the same thing except a node is passed as an argument. "minimum and maximum" in that case simply becomes a helper function for the same "ceiling and flooring" functions with the passed node being the root. Once again, sorry for the delay and thanks!

vladaionescu commented

2016-06-06 23:14:36 +00:00

(Migrated from github.com)