golibs/gms-gods
Watch
1
0
Fork
You've already forked gms-gods
 0
Code Issues 3 Pull requests 7 Projects Releases 24 Packages Activity Actions

Remove unnecessary comparable type constraints from data structures #244

Open
sleepymole wants to merge 1 commit from sleepymole/master into master
pull from: sleepymole/master
merge into: golibs:master
Conversation 3 Commits 1 Files changed 42 +370 -92
sleepymole commented 2024-03-08 05:08:11 +00:00 (Migrated from github.com)

Close https://github.com/emirpasic/gods/issues/243.

Some data structures support custom comparators. In these cases, the generic type constraint does not need to be comparable. This PR removes the unnecessary comparable type constraints from these data structures.

Close https://github.com/emirpasic/gods/issues/243. Some data structures support custom comparators. In these cases, the generic type constraint does not need to be comparable. This PR removes the unnecessary comparable type constraints from these data structures.
👍 2 🚀 1
sonarqubecloud[bot] commented 2024-03-08 05:08:23 +00:00 (Migrated from github.com)

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=gods&pullRequest=244) **Quality Gate passed** Issues ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 New issues](https://sonarcloud.io/project/issues?id=gods&pullRequest=244&resolved=false&inNewCodePeriod=true) ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/component_measures?id=gods&pullRequest=244&metric=new_accepted_issues&view=list) Measures ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=gods&pullRequest=244&resolved=false&inNewCodePeriod=true) ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png '') No data about Coverage ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png '') No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=gods&pullRequest=244)
Seb-C commented 2024-06-01 08:04:17 +00:00 (Migrated from github.com)

I also need this if I want to migrate to the v2. When can we expect a review?

I also need this if I want to migrate to the v2. When can we expect a review?
🚀 1
doraemonkeys commented 2024-08-17 03:33:51 +00:00 (Migrated from github.com)

@emirpasic Could you please review and consider merging it soon?

@emirpasic Could you please review and consider merging it soon?
This pull request has changes conflicting with the target branch.
  • internal/treeenc/treeenc.go
  • internal/treeenc/treeenc_test.go
  • lists/doublylinkedlist/doublylinkedlist.go
  • lists/singlylinkedlist/singlylinkedlist.go
  • maps/treebidimap/serialization.go
  • queues/circularbuffer/circularbuffer.go
  • trees/avltree/avltree.go
  • trees/avltree/serialization.go
  • trees/binaryheap/binaryheap.go
  • trees/btree/serialization.go
  • trees/redblacktree/redblacktree.go
  • trees/redblacktree/serialization.go
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin "sleepymole/master:sleepymole/master"
git switch "sleepymole/master"

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch "master"
git merge --no-ff "sleepymole/master"
git switch "sleepymole/master"
git rebase "master"
git switch "master"
git merge --ff-only "sleepymole/master"
git switch "sleepymole/master"
git rebase "master"
git switch "master"
git merge --no-ff "sleepymole/master"
git switch "master"
git merge --squash "sleepymole/master"
git switch "master"
git merge --ff-only "sleepymole/master"
git switch "master"
git merge "sleepymole/master"
git push origin "master"
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
discussion

   
documentation

   
duplicate

   
ignore

   
new feature

   
question
No labels
bug
discussion
documentation
duplicate
ignore
new feature
question
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
golibs/gms-gods!244
No description provided.