Support rendering Table elements #19

New issue

Open

opened 2024-01-11 17:09:56 +00:00 by gen2thomas · 3 comments

gen2thomas commented

2024-01-11 17:09:56 +00:00

(Migrated from github.com)

First, thanks for this small and nice renderer and the description in the README and provided examples!

After parsing a document with table extension, like this:

gm := goldmark.New(goldmark.WithExtensions(extension.Table))

...the resulting document is a "little bit destroyed", this seems to be caused by the missing "KindTable" for the renderer.

Is there a plan to implement it or would this be possible by a custom extension, e.g. with this PR #16 ?

First, thanks for this small and nice renderer and the description in the README and provided examples! After parsing a document with table extension, like this: `gm := goldmark.New(goldmark.WithExtensions(extension.Table))` ...the resulting document is a "little bit destroyed", this seems to be caused by the missing "KindTable" for the renderer. Is there a plan to implement it or would this be possible by a custom extension, e.g. with this PR #16 ?

gen2thomas commented

2024-01-12 19:09:22 +00:00

(Migrated from github.com)

maybe this would help with the implementation: https://github.com/Kunde21/markdownfmt/blob/master/markdown/renderer_table.go

teekennedy commented

2024-01-17 06:21:45 +00:00

(Migrated from github.com)

Hi @gen2thomas thanks for the suggestions and glad you found the repo to be nice!

I'll look into adding the missing test coverage for #16 as well as adding support for the table extension directly. I was planning on adding support for all extensions in GitHub Flavored Markdown but got sidetracked with other projects.

Hi @gen2thomas thanks for the suggestions and glad you found the repo to be nice! I'll look into adding the missing test coverage for #16 as well as adding support for the table extension directly. I was planning on adding support for all extensions in GitHub Flavored Markdown but got sidetracked with other projects.

👍 1

teekennedy commented

2024-02-08 05:57:20 +00:00

(Migrated from github.com)