Extra space, no name? #4

New issue

Closed

opened 2020-07-22 08:27:28 +00:00 by runeimp · 2 comments

runeimp commented

2020-07-22 08:27:28 +00:00

(Migrated from github.com)

I was just trying your dataurl command line tool and the output of encoding an HTML file was data:text/html; charset=utf-8;base64,... instead of data:text/html;charset=utf-8;base64,.... I'm guessing the tool is intending to put name=index.html; where the space is before charset. But is failing for some reason.

I was just trying your dataurl command line tool and the output of encoding an HTML file was `data:text/html; charset=utf-8;base64,...` instead of `data:text/html;charset=utf-8;base64,...`. I'm guessing the tool is intending to put `name=index.html;` where the space is before `charset`. But is failing for some reason.

runeimp commented

2020-10-08 01:37:10 +00:00

(Migrated from github.com)

Any chance of this getting looked at? It's been over two months since this issue was posted and it's the only open issue in the repo. An acknowledgement that this was seen and your currently too busy to look into it would be fine.

vincent-petithory commented

2020-10-09 15:22:20 +00:00

(Migrated from github.com)

@runeimp The space actually comes from mime.TypeByExtension() . There is currently no behavior to add the name parameter when encoding a file. That's something that could be done easily though.

@runeimp The space actually comes from `mime.TypeByExtension()` . There is currently no behavior to add the `name` parameter when encoding a file. That's something that could be done easily though.